client: stop propagation when hiding the chat through click/tapping the chat #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, good call. I don't tend to have this problem much, but I think that's because I have gotten used to only closing with using the menu button. I'll 👍 it but wait for another. |
AlMcKinlay
added
the
Type: Bug
|
That's one of the things I pointed out in @maxpoulin64's PR. 👍 |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…prevent-default client: stop propagation when hiding the chat through click/tapping the chat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really annoying on mobile. When I click the chat to hide the side menu 9 times out of 10 I hit a nickname.