Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slight bugs introduced by #379 and #465 #467

Merged
merged 2 commits into from
Jul 6, 2016
Merged

Fix slight bugs introduced by #379 and #465 #467

merged 2 commits into from
Jul 6, 2016

Conversation

maxpoulin64
Copy link
Member

No description provided.

@maxpoulin64 maxpoulin64 added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. second review needed labels Jul 6, 2016
@maxpoulin64 maxpoulin64 added this to the 2.0.0 milestone Jul 6, 2016
@AlMcKinlay
Copy link
Member

👍 and merging

@AlMcKinlay AlMcKinlay merged commit 548a8d7 into master Jul 6, 2016
@AlMcKinlay AlMcKinlay deleted the PR/oops branch July 6, 2016 09:53
color: #dcdccc;
background-color: #434443 !important;
border-color: #101010 !important;
color: #dcdccc !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hummmmm isn't there a better way than adding all these !important?
Removing one is a small victory so adding five...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be possible, yes. But we're already fighting for the style in the main stylesheet and I didn't feel like making a mess of selectors. But yeah, I should have taken the time but it was late and I wanted to get it fixed ASAP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
@AlMcKinlay AlMcKinlay removed their assignment Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants