Ignore unnecessary files at release time

[astorije]

• client/views/ contains templates whose built version is provided with each releases
• .gitignore doesn't appear in our releases, but I'm not sure if this comes from npm itself or Travis CI publishing for us. Adding it here for completeness. None of the documentations (npm or Travis CI) mentions this explicitly, so ¯_(ツ)_/¯. If someone knows more about this, please share.
• Surprisingly, .npmignore itself is not ignored...
• All other files and directories are for development purposes only

[AlMcKinlay]

Looks good to me.

Regarding .gitignore being ignored, it appears that is because of npm: issue here. However, no one seems to explain why this is the case.

tl;dr If .npmignore doesn't exist, the .gitignore gets renamed to .npmignore in the package. If .npmignore exists, .gitignore is just ignored. You can't change this either, as putting !.gitignore doesn't fix it. So there literally seems no way to get .gitignore into an npm package without renaming it.

But I agree to keep it in there, because I expect this will be fixed at some point, and it future proofs us.

Only question is: have you checked what happens when you install the package without all these things? It will try and rerun the build, because we have the build on prepublish, which is run on publish and install. So I imagine this would fail.

[astorije]

Only question is: have you checked what happens when you install the package without all these things? It will try and rerun the build, because we have the build on prepublish, which is run on publish and install. So I imagine this would fail.

Running the build doesn't apply when you run npm install thelounge[@next], it is only run when calling npm install without arguments. From the doc:

• prepublish: Run BEFORE the package is published. (Also run on local npm install without any arguments.)

This is also why things that are part of the build (like the font-awesome package, or grunt) are listed in dependencies and not devDependencies: they would not be installed in a production environment.

[AlMcKinlay]

Alright, well 👍 from me then. Looks sensible.