Use min-height of textarea when computing auto-resize after deleting a char #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
Type: Bug
| @@ -1260,6 +1260,7 @@ button { | |||
| } | |||
|
|
|||
| #form #input { | |||
| overflow-y: hidden; | |||
There was a problem hiding this comment.
This will break scrolling when it hits 6-7 lines, as we stop growing at this point.
There was a problem hiding this comment.
Right, good point, I'll remove this.
|
Functionality-wise works fine, 👍 (except the overflow issue) |
astorije
force-pushed
the
astorije/fix-reset-textarea-height
branch
2 times, most recently
from
332ee84
to
6abb9f1
Compare
astorije
changed the title
astorije
force-pushed
the
astorije/fix-reset-textarea-height
branch
from
6abb9f1
to
cc06081
Compare
astorije
force-pushed
the
astorije/fix-reset-textarea-height
branch
from
cc06081
to
27b33f4
Compare
|
@maxpoulin64 is 👍 (but didn't comment with 👍 itself, just the second-review label). All other maintainers are away at the moment, but @williamboman did test this successfully, so merging. |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…xtarea-height Use min-height of textarea when computing auto-resize after deleting a char
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #482.
This fixes a bug that was breaking the textarea on Android.
@williamboman, can you give it a try?