Restore padding and height of message input pre-textarea era #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
Type: Bug
|
Yeah I knew it felt a bit off but I couldn't really figure out what was wrong exactly. The total height was the same and it aligned fine in morning/zenburn so I didn't know what it was. Nice find! |
|
Oh now that you say it, I forgot to check how other themes were handling
this :-/
I should check that ASAP...
|
|
Forgot to post back here: I tested with themes and everything looks fine. It may be that the nick appears a pixel down in some of the themes, but apart from that (not even certain), we're good. |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…t-margin Restore padding and height of message input pre-textarea era
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Margins around the nick, and overall height of the input, perfectly set prior to the textarea introduction. Turns out, there was also a 1px-offset in there, and I could see something was off without being able to pinpoint what exactly.
Not sure how long the current style of textarea will stay around, but this PR at least puts things back in order until then.
I have played a looot with this, adding and removing stuff, when in the end the changes are just because now the border is set on a different element, and we all know how CSS is a bit bitchy about how overall heights and margins are set depending on the border.
Results