Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure input height is reset when submitting with icon #555

Merged
merged 1 commit into from
Aug 11, 2016

Conversation

astorije
Copy link
Member

This is especially noticeable on mobile, where clicking Send icon is more natural.

Before After
input-no-reset-height input-reset-height

(The screenshots show an extra empty line in the textarea, this is an unrelated bug that I haven't had the chance to debug yet. Help welcome 😄)

This is especially noticeable on mobile, where clicking Send icon is more natural.
@astorije astorije added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. second review needed labels Aug 11, 2016
@astorije astorije added this to the 2.0.0 milestone Aug 11, 2016
@maxpoulin64 maxpoulin64 merged commit 4ddaa9a into master Aug 11, 2016
@maxpoulin64 maxpoulin64 deleted the astorije/fix-reset-height branch August 11, 2016 05:46
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
…ight

Make sure input height is reset when submitting with icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants