Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove font family redundancy, fix missed fonts, remove Open Sans #562

Merged
merged 1 commit into from
Sep 3, 2016

Conversation

astorije
Copy link
Member

This fixes #138 and #81.

Initially, I was just trying to rebase #377 with master. I noticed a lot of issues with it and ended up completely redoing it.

A few things:

  • There should be no visual changes on the default style, except the title + topic in the headers which are a bit more aligned.
  • This fixes a few bugs, such as a use of Leto instead of Lato, missed fonts in some of the themes.
  • Crypto will require a bit more fixing to be fully non-redundant, but this is for another PR.
  • Zenburn and Morning now only use Lato instead of Lato + Open Sans, as these 2 are very similar. Users of these themes will notice a difference, but I'm ready to bet they did not realize their theme was actually using 2 fonts.
  • This was discussed and agreed many times, but working on this PR was a massive pain in the butt because of that overriding situation. My next step once this gets merged is to move the font-family declarations of the default theme to example.css (which we should rename to give it a real name, maybe even just Default) and fix the themes accordingly. Looking at existing issues, we already agreed to that, but pinging @thelounge/maintainers here just so they know.

@astorije astorije added Type: Feature Tickets that describe a desired feature or PRs that add them to the project. second review needed labels Aug 14, 2016
@astorije astorije added this to the 2.0.0 milestone Aug 14, 2016
@astorije
Copy link
Member Author

Any takers? I won't have fun fixing potential conflicts on this one :D

@AlMcKinlay
Copy link
Member

Yeah, looks fine to me. 👍

@AlMcKinlay AlMcKinlay self-assigned this Sep 2, 2016
@astorije astorije merged commit b66c538 into master Sep 3, 2016
@astorije astorije deleted the astorije/css-redundancy-fix-2 branch September 3, 2016 02:37
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
…cy-fix-2

Remove font family redundancy, fix missed fonts, remove Open Sans
@AlMcKinlay AlMcKinlay removed their assignment Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix font declarations to inherit from body
2 participants