Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set app orientation in manifest to use user setting at OS level #587

Merged
merged 1 commit into from
Sep 3, 2016

Conversation

astorije
Copy link
Member

Fixes #586.

Turns out, when this setting is not set, the auto-rotate being on or off is respected as expected. Who knew!

I know @YaManicKill and @vectr0n have been testing on different devices, would be great if you guys could confirm :-)
Maybe an iOS user should confirm that things are fine on this side as well.

(I have also tried with natural, but that doesn't work for us: it means portrait for phones and landscape for tablets).

@astorije astorije added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. second review needed labels Aug 31, 2016
@astorije astorije added this to the 2.0.0 milestone Aug 31, 2016
@AlMcKinlay
Copy link
Member

Well, that's a confusing setting. I would have assumed that "orientation: any" meant that it can be any, but not that it would force it into being any. Will test this later today.

@astorije
Copy link
Member Author

I know!! That what kind of a desperate move to be honest, I was not expecting that to work, but yet it did 😅

@AlMcKinlay
Copy link
Member

Yeah, this looks fine.

From what I can see, it looks like the default is "natural" for Chrome, which I think respects the device's orientation lock.

It might be worth thinking about specifically putting this in incase any other browsers use a different default, but I'm happy either way.

👍 but I'll let you merge.

@astorije
Copy link
Member Author

astorije commented Sep 3, 2016

From what I can see, it looks like the default is "natural" for Chrome, which I think respects the device's orientation lock.

Actually, default is supposed to be any (but in practice, it's not all the time, as we are seeing here). natural means that default orientation for a given device is being used, but when I tested, it didn't respect the orientation lock.
Thing is a mess, but to be fair the whole specification for this is still a draft, so I'm guessing changes will happen. That's fine, we'll adjust when browsers do :-)

@astorije astorije merged commit 5332909 into master Sep 3, 2016
@astorije astorije deleted the astorije/fix-orientation branch September 3, 2016 05:47
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Do not set app orientation in manifest to use user setting at OS level
@AlMcKinlay AlMcKinlay removed their assignment Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants