Disable pull-to-refresh on mobile that conflicts with scrolling the message list #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
Type: Bug
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…-to-refresh Disable pull-to-refresh on mobile that conflicts with scrolling the message list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, if to scroll down the messages but by accident start on the topic instead of the chat window, bye bye, this refreshes the entire app, losing the current scroll position. One of the most annoying small UX issues at the moment, IMO.
See option 3 of http://stackoverflow.com/a/29313685/1935861. IMO this is the least error-prone and aggressive of the 3 options (option 4 does not apply).
(Marking as
Do not mergeas this is not critical and should wait for 2.0.0 release to be merged)