Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CI caches for downloaded files instead of installed ones #687

Merged
merged 1 commit into from Oct 15, 2016

Conversation

astorije
Copy link
Member

This allows for a more meaningful build: if a newer version of a sub-package breaks, builds would still pass as it uses the cached version. This uses a cache for downloaded packages instead.

I am expecting this to slow down a little bit the builds (but we are OK overall) but be more accurate in practice.

See https://docs.npmjs.com/cli/cache#configuration and https://docs.npmjs.com/files/folders#node-modules.

@astorije astorije added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Oct 12, 2016
This allows for a more meaningful build: if a newer version of a sub-package breaks,
builds would still pass as it uses the cached version. This uses a cache for downloaded packages instead.

I am expecting this to slow down a little bit the builds (but we are OK overall)
but be more accurate in practice.

See https://docs.npmjs.com/cli/cache#configuration and https://docs.npmjs.com/files/folders#node-modules.
Copy link
Member

@xPaw xPaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing github hook!

@astorije astorije merged commit 3a00175 into master Oct 15, 2016
@astorije astorije deleted the astorije/ci-caches branch October 15, 2016 03:31
@xPaw xPaw added this to the 2.1.0 milestone Oct 15, 2016
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Use CI caches for downloaded files instead of installed ones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants