Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print node version and platform #743

Merged
merged 1 commit into from Nov 20, 2016
Merged

Print node version and platform #743

merged 1 commit into from Nov 20, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Nov 18, 2016

Fixes #742

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Nov 18, 2016
@xPaw xPaw added this to the 2.2.0 milestone Nov 18, 2016
@xPaw xPaw self-assigned this Nov 19, 2016
@astorije
Copy link
Member

For the record, a before/after of this:

Before After
screen shot 2016-11-19 at 23 01 00 screen shot 2016-11-19 at 23 02 06

This is so fancy! 💅

astorije
astorije approved these changes Nov 20, 2016
View reviewed changes
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be reasonable to leave this job to node -v, but why not :)

@astorije astorije merged commit d8ef28c into master Nov 20, 2016
@astorije astorije deleted the xpaw/print-node-version branch November 20, 2016 04:05
@astorije astorije self-assigned this Nov 20, 2016
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
@astorije
Merge pull request thelounge#743 from thelounge/xpaw/print-node-version
d1a2624 
Print node version and platform
@xPaw xPaw unassigned astorije and xPaw Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

Assignees
No one assigned
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xPaw @astorije