Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify introduction on README #789

Merged
merged 1 commit into from Dec 16, 2016
Merged

Conversation

astorije
Copy link
Member

@astorije astorije commented Dec 11, 2016

Features listed here are the same as on Shout repo, in same order, participating to the feeling of fork with nothing new. Instead of listing features here, we should refer to the website and improve it to make it as current as possible (there was some recent action there, and more coming, so it is reasonable to point there).

Also, this "Why the fork?" section was useful right when we forked, but now it gives unnecessary and lengthy information (it is now the most verbose section of the README!). The Lounge has enough momentum as that point to be treated as its own project.

Finally, shortening this section moves the screenshot back up on the page, and mobile view now has more context in the description.

Before After
screen shot 2016-12-11 at 04 16 18 screen shot 2016-12-11 at 04 16 04

Features listed here are the same as on Shout repo, in same order, participating to the feeling of fork with nothing new. Instead of listing features here, we should refer to the website and improve it to make it as current as possible (there was some recent action there, and more coming, so it is reasonable to point there).

Also, this "Why the fork?" section was useful right when we forked, but now it gives unnecessary and lengthy information (it is now the most verbose section of the README!). The Lounge has enough momentum as that point to be treated as its own project.

Finally, shortening this section moves the screenshot back up on the page, and mobile view now has more context in the description.
@astorije astorije added Type: Documentation Lack of documentation, improvement suggestion, or PRs that address these. Type: Feature Tickets that describe a desired feature or PRs that add them to the project. labels Dec 11, 2016
@astorije astorije added this to the 2.2.0 milestone Dec 11, 2016
@astorije
Copy link
Member Author

We can improve the intro a bit now or more later, but moving away from the current layout, pretty much a 1:1 copy of Shout's README, is a good thing IMO.

@astorije astorije removed this from the 2.2.0 milestone Dec 11, 2016
@xPaw
Copy link
Member

xPaw commented Dec 11, 2016

IMO, readme should list a couple of features (doesn't have to be an actual list).

@astorije
Copy link
Member Author

Fine by me (that's what I meant in my previous comment): which ones would you see there?

Copy link
Member

@AlMcKinlay AlMcKinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm not really sure what features we would write that it doesn't already show in the screenshot. I'm happy with this. If @xPaw wants a couple of things added, then I'm also fine with that.

@AlMcKinlay AlMcKinlay self-assigned this Dec 12, 2016
@xPaw xPaw merged commit 2d09e09 into master Dec 16, 2016
@xPaw xPaw deleted the astorije/simpler-readme-intro branch December 16, 2016 19:12
@astorije astorije added this to the 2.2.0 milestone Dec 16, 2016
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
…me-intro

Simplify introduction on README
@AlMcKinlay AlMcKinlay removed their assignment Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Lack of documentation, improvement suggestion, or PRs that address these. Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants