Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remind channel name or nick in input placeholder #832

Merged
merged 2 commits into from Dec 21, 2016

Conversation

astorije
Copy link
Member

@astorije astorije commented Dec 21, 2016

Closes #343.

Result on small device:

screen shot 2016-12-20 at 20 11 38 screen shot 2016-12-20 at 20 42 49

(Content is different only because I messed up my screenshots, it's 2 different windows 😅)

@astorije astorije added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Dec 21, 2016
@MaxLeiter
Copy link
Member

I think this is unnecessary clutter on the desktop - maybe hide it there?

@astorije
Copy link
Member Author

Nah, I think it's just as valuable on desktop than mobile. I was kinda not fond of the idea at first, but you get used to it in 5 seconds and it's actually not bad to have it there.

Slack added this fairly recently too, pretty sure some people complained about accidentally messaging the wrong coworkers :D

@astorije
Copy link
Member Author

@MaxLeiter, once this is enabled, if you really don't like it, you can easily hide it with #input::-webkit-input-placeholder { opacity: 0; } (or visibility: hidden), using the prefix you need, in your custom CSS.
It's not possible for someone to display this otherwise though.

@MaxLeiter
Copy link
Member

That's fine, but sidenote: I really think we should avoid a "you can use custom CSS if you don't like it" mentality, because we shouldn't assume the average user understands CSS (or even knows that box exists).

Can't wait for tabbed-page settings (or some equivalent)...

@astorije
Copy link
Member Author

but sidenote: I really think we should avoid a "you can use custom CSS if you don't like it" mentality, because we shouldn't assume the average user understands CSS

I completely agree with you on this, we should make an app that's optimal and well-thought in the first place, and leave that custom CSS to those of us who have very specific and sometimes weird requirements.
In this case however, I'm with @xPaw and @YaManicKill, I think it makes for a better user experience.

@astorije astorije requested a review from xPaw December 21, 2016 04:06
Copy link
Member

@AlMcKinlay AlMcKinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, seems fine to me. Can't think of a better way of doing it, so looks good :-)

@astorije astorije added this to the 2.2.0 milestone Dec 21, 2016
@astorije astorije merged commit 0489d0f into master Dec 21, 2016
@astorije astorije deleted the astorije/context-aware-placeholder branch December 21, 2016 23:16
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
…e-placeholder

Remind channel name or nick in input placeholder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants