Un-ellipsis placeholder and use ES6 template #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
the
Type: Feature
|
If reviewer is happy with it, feel free to merge and add to v2.2.0 as it's a minor improvement over a feature introduced in v2.2.0. Heck, this PR doesn't even deserve a change log entry if it makes it to v2.2.0. |
xPaw
approved these changes
Jan 25, 2017
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Un-ellipsis placeholder and use ES6 template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what I was thinking in #832 but I am really annoyed by the looks of it in practice.
Plus that way there is a bit of extra room in case screen isn't wide enough. Very unlikely, but if it happens, that would be a few missing chars at best, so why not.
Also hey, first ES6 feature on the client right there.