Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent message sending in lobbies #957

Merged
merged 1 commit into from Mar 13, 2017
Merged

Prevent message sending in lobbies #957

merged 1 commit into from Mar 13, 2017

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Mar 11, 2017

Fixes #956.

Prevents /me, /slap, /kick, /topic being used in lobbies. Ideally some of these commands should support specifying target channel like /invite, but as they currently do not, it blocks and prints a message.

@xPaw xPaw added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. Type: Security Security concern or PRs that must be reviewed with extra care regarding security. labels Mar 11, 2017
@xPaw xPaw added this to the 2.2.2 milestone Mar 11, 2017
@astorije astorije merged commit bdf4a93 into master Mar 13, 2017
@astorije astorije deleted the xpaw/harden-lobby branch March 13, 2017 03:52
@astorije astorije removed the Type: Security Security concern or PRs that must be reviewed with extra care regarding security. label Mar 13, 2017
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants