Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong font size in help center labels #994

Merged
merged 1 commit into from Mar 30, 2017
Merged

Conversation

astorije
Copy link
Member

This only concerns plain texts, not <code> or <kbd>.

This is veeery subtle at the moment (which is why I missed it) but I noticed the labels were in 16px when testing #787 that currently has texts in the labels (that will change, but still, makes / and + using the correct size).

Before After
screen shot 2017-03-30 at 02 18 05 screen shot 2017-03-30 at 02 18 23

This only concerns plain texts, not `<code>` or `<kbd>`.
@astorije astorije added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Mar 30, 2017
@astorije astorije added this to the 2.3.0 milestone Mar 30, 2017
@xPaw xPaw merged commit 2c6f525 into master Mar 30, 2017
@xPaw xPaw deleted the astorije/fix-height-help branch March 30, 2017 06:51
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants