Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified all Dockerfile to add lounge user and set permissions on the… #31

Closed
wants to merge 1 commit into from

Conversation

Need-To-Learn
Copy link

… /home/needtolearn/data folder

Hi,
I think it's a good practice to not run app as root user.
So I modified the three Dockerfile to add an user 'lounge' and set right permissions on the $HOME/data folder.

@williamboman
Copy link
Member

williamboman commented May 2, 2017

The container actually ran as non-root user before, but we dropped it (in #17) because of volume permission hassle. I'd definitely prefer not to run it as root but due to the amount of people with varying Docker experience that use the official images I'd rather run as root than deal with support (maybe proper documentation will help mitigate that).

I wouldn't say I have very detailed knowledge about the security implications of running containers in privileged mode, my conception is that the only reason not to run as root is if you believe there are flaws (or hedge against potential flaws) in LXC and/or Docker-specific virtualization/containerization implementation. Please reopen this if you strongly disagree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants