Improve links on alerts #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
reviewed
Nov 5, 2018
This is the colors straight from Bootstrap, however we cannot just switch to using Bootstrap for this as it expects links within alerts to be given the class `alert-link`, which the Markdown compiler obviously does not do.
xPaw
force-pushed
the
astorije/alert-links
branch
from
4a60381
to
9dc1062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the colors straight from Bootstrap, however we cannot just switch to using Bootstrap for this as it expects links within alerts to be given the class
alert-link, which the Markdown compiler obviously does not do.See https://getbootstrap.com/docs/3.3/components/#alerts-links.