-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow robots in non-production #175
Conversation
Preview of your commit: https://5be9646fe47085303512ed78--thelounge.netlify.com/robots.txt It seems to have worked to me. |
c67db32
to
41bb7ad
Compare
Wondering, by "non-production", did you intend this to differentiate builds for main website vs. deploy previews / next website? If so then the environment variable way set to |
Yes.
Why did you approve the PR then, is there something else required to be set? I see you set Build environment variables, but wouldn't that apply to all deploys/previews? |
There's this plugin: https://github.com/jayvdb/jekyll-netlify Which seems to set jekyll env based on netlify context. |
Because I initially thought it was to distinguish between dev and non-dev. I think. That was a while ago.
Correct.
I did see this, do you want to play with it? |
I don't have ruby installed (nor can I be bothered to install it, haha) to update the gemfile correctly. |
@xPaw, thoughts? https://deploy-preview-175--thelounge.netlify.com/robots.txt correctly shows |
Looks good |
Fixes #172. Got the example from https://github.com/twbs/bootstrap/blob/110c7f4cc0c5693583e0e69bdde3465c934b6e58/site/robots.txt
The question is: does netlify actually set
environment: production
when building for production/master?