-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redirect for themes.html
#181
Conversation
I'm really confused, the URLs without .html used to redirect fine. I remember specifically testing that, I wonder what broke it. There is some sort of precedence in how they handle 1) removing the .html 2) checking the redirects file. This tells me I got the precedence wrong (again, wondering why since it used to work). So instead of adding a |
75f9060
to
aa08744
Compare
Yeah that doesn't work, we have to specify both .html and no .html versions... It probably broke when we 'fixed' .html removal on existing pages. |
aa08744
to
ddb6c16
Compare
ddb6c16
to
b0f88ba
Compare
That doesn't feel right, I'm pretty sure their engine used to normalize stuff first. Let me reach out to them and show them this. |
Did you reach them? I'd say we do this for now, until we find a better solution. |
I did, twice in fact, and it looks like my messages got dropped on their support system, that's annoying. I'll reach out again. EDIT: Done, will follow-up here when I have news. |
So this is the answer I got from them:
So it seems like duplicates are the only way to go, bit of a shame. I'm not sure it's worth the maintenance effort of dynamically generating the file however when a handful of duplicates would do. |
It's linked here: https://github.com/thelounge/thelounge/blob/dedaa1f33767b94bf3c2f0208a37e6877800d248/defaults/config.js#L68
If you try going to
next
subdomain, it 404s instead of redirecting.Perhaps we need a
*.html
redirect or specify all the other rewrites with.html
?