Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide "Identify users with identd or oident" #192

Merged
merged 6 commits into from
Jan 8, 2019
Merged

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Jan 6, 2019

Fix #147

_guides/identdfile.md Outdated Show resolved Hide resolved
_guides/identdfile.md Outdated Show resolved Hide resolved
_guides/identdfile.md Outdated Show resolved Hide resolved
_guides/identdfile.md Outdated Show resolved Hide resolved
_guides/identdfile.md Outdated Show resolved Hide resolved
_guides/identdfile.md Outdated Show resolved Hide resolved
@astorije
Copy link
Member

astorije commented Jan 7, 2019

@xPaw, after reading this, I still have no idea what identd/oidentd is and how it relates to The Lounge. Mind adding a short intro about it and maybe a link to a more comprehensive guide?

I'm not saying we need a full-fledged article on what it is, but a few sentences about what it is, what it does when used with The Lounge, and who it applies for / why would I need this, would be very helpful IMO.

astorije and others added 2 commits January 7, 2019 10:57
Co-Authored-By: xPaw <xPaw@users.noreply.github.com>
@xPaw
Copy link
Member Author

xPaw commented Jan 7, 2019

@astorije Added some extra wording.

_guides/identdfile.md Outdated Show resolved Hide resolved
_guides/identdfile.md Outdated Show resolved Hide resolved
_guides/identdfile.md Outdated Show resolved Hide resolved
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid guide, I like! Left a couple comments but still good overall.

One question: URL is /docs/guides/identdfile, I'm assuming you're okay with that? I was initially thinking more of /docs/guides/identd-and-oidentd or similar, but not feeling strongly either.

@xPaw xPaw merged commit 08d8ecd into master Jan 8, 2019
@xPaw xPaw deleted the guide/ident branch January 8, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants