Update https.md #244
Closed
Update https.md #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version of tutorial is outdated because certbot-auto is deprecated.
Actually you don't need to restart The Lounge after certificate renewal.
brunnre8
reviewed
Jun 24, 2021
| @@ -7,24 +7,33 @@ description: Easily configure The Lounge to be served over HTTPS for better secu | |||
| In this guide, we will see how to easily configure The Lounge to be served over [HTTPS](https://en.wikipedia.org/wiki/HTTPS) for better security and privacy. | |||
|
|
|||
| {: .alert.alert-warning role="alert"} | |||
| The Lounge only has basic HTTPS support, and will need to be manually restarted to reload certificates on renewal. For advanced HTTPS support, consider [using a reverse proxy](/docs/guides/reverse-proxies). | |||
| The Lounge only has basic HTTPS support. | |||
|
|
|||
There was a problem hiding this comment.
Please don't remove the reverse proxy docs, that's actually what should be referred to, not just an nginx config that only works on some distributions.
|
|
||
| 1. Install nginx with `sudo apt install nginx`. | ||
| 2. Create configuration file for your domain with `sudo nano /etc/nginx/sites-available/thelounge.example.com` | ||
| 3. Paste code below: | ||
| ``` |
There was a problem hiding this comment.
This is not an improvement over the reverse proxy docs, you are essentially writing an opinionated guide that only works on Debian / Ubuntu specific distros.
/etc/nginx/sites-enabled/ doesn't do anything if you don't have nginx setup to include those configs.
/etc/nginx/sites-available is just an admin convention, nginx doesn't care about it.
| 5. Enable the configuration file with `sudo ln -s /etc/nginx/sites-available/thelounge.example.com /etc/nginx/sites-enabled/thelounge.example.com` | ||
| 6. Check the configuration file for errors with `sudo nginx -t` | ||
| 7. If there's no errors, restart nginx with `sudo systemctl restart nginx` | ||
| 8. Next, install certbot with `sudo apt install certbot python3-certbot-nginx` |
There was a problem hiding this comment.
debian / ubuntu specific things again
|
Closing this, as it seems stalled and is too distro specific to be merged as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version of tutorial is outdated because certbot-auto is deprecated.
I forgot to say you don't need to restart The Lounge after certificate renewal. :/
Tested on Ubuntu 20.04 VPS. Hence
aptis my package manager.