Remove distro-specific install instructions of Node.js #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main issue with our documentation is that it was advising to install a version of Node that is not compatible with The Lounge! These instructions will clearly need improvements to make good use of what's done in https://github.com/thelounge/docker-lounge, https://github.com/thelounge/deb-lounge and https://github.com/thelounge/arch-lounge, but until then, it fixes the current issue.
This was referenced Dec 8, 2016
AlMcKinlay
approved these changes
Dec 8, 2016
|
We should probably also link to the three repos you mentioned on the actual projects README as well |
|
One thing at a time :) These have further implications that I prefer to deal with later. For now it's fixing instructions that are simply wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48, fixes #25, supersedes #44.
The main issue with our documentation is that it was advising to install a version of Node that is not compatible with The Lounge!
Turns out, when you remove all the distro-specific instructions for Node on the current version of https://thelounge.github.io/docs/getting_started/install.html, you are left with
npm install -g theloungeonly 馃槀.These instructions will clearly need improvements to make good use of what's done in https://github.com/thelounge/docker-lounge, https://github.com/thelounge/deb-lounge and https://github.com/thelounge/arch-lounge, but until then, it fixes the current issue.