Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel sorting broken #1088

Closed
PolarizedIons opened this issue Apr 26, 2017 · 11 comments · Fixed by #1115
Closed

Channel sorting broken #1088

PolarizedIons opened this issue Apr 26, 2017 · 11 comments · Fixed by #1115
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Milestone

Comments

@PolarizedIons
Copy link
Contributor

PolarizedIons commented Apr 26, 2017

Running on master (dd5e50f).

As you can see the order is messed up when syncing to other clients, but the strange order also persists when refreshing. (Also note how the network lobby isn't where it should be)

https://gfycat.com/TalkativeKindlyAlbino

@AlMcKinlay AlMcKinlay added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Apr 26, 2017
@AlMcKinlay
Copy link
Member

Assuming this is due to #1064

@AlMcKinlay AlMcKinlay added this to the 2.3.0 milestone Apr 26, 2017
@AlMcKinlay
Copy link
Member

AlMcKinlay commented Apr 26, 2017

Interestingly I'm not able to reproduce it. Have you ensured you did an npm run build, @PolarizedIons (not that this should make a difference for this particular issue, one would think)

@PolarizedIons
Copy link
Contributor Author

Yep I did, @YaManicKill. Recloned to be sure and still an issue.

@astorije
Copy link
Member

Pinging @xPaw about this.

@bews
Copy link
Contributor

bews commented Apr 26, 2017

I don't have this problem. @PolarizedIons are you sure it's not a local change? Also, what browser do you use?

@PolarizedIons
Copy link
Contributor Author

@bews Chromium Version 58.0.3029.81 (64-bit) on Arch Linux, but the fact that it persisted after a refresh (and diffrent in fact) leads me to believe it isn't a browser issue. No local changes - I did a fresh reclone to test that

@williamboman
Copy link
Member

FWIW, I can repro in Safari and Chromium

@xPaw
Copy link
Member

xPaw commented Apr 26, 2017

Probably #1064 broke it, unsure why though.

@PolarizedIons
Copy link
Contributor Author

Just adding more info to this: it doesn't seem to happen when you "manually" join networks/channels. I connect though ZNC so it could be caused by that, or the amount of channels/queries it opens

@xPaw
Copy link
Member

xPaw commented Apr 27, 2017

I can't reproduce this. I also connect to ZNC.

@PolarizedIons
Copy link
Contributor Author

Fixed in #1115. I think the ZNC thing was just a red herring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants