Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link preview button shown on invalid links #1173

Closed
MiniDigger opened this issue May 18, 2017 · 1 comment · Fixed by #1276
Closed

Link preview button shown on invalid links #1173

MiniDigger opened this issue May 18, 2017 · 1 comment · Fixed by #1276
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Milestone
2.4.0

Comments

@MiniDigger
Copy link
Contributor

if a message contains https://, without an actual url, it will still show the button to expand the link preview.
running master (36 commits behind, some custom stuff), but avieks in irc could reproduce for 2.2.2.
@raqbit
Copy link
Contributor

raqbit commented May 18, 2017

Can reproduce here on 2.2.2

@xPaw xPaw closed this as completed May 18, 2017
@xPaw xPaw added this to the 2.3.0 milestone May 18, 2017
@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label May 18, 2017
@xPaw xPaw removed this from the 2.3.0 milestone May 18, 2017
@xPaw xPaw reopened this May 18, 2017
@xPaw xPaw added this to the 2.3.3 milestone Jun 26, 2017
@xPaw xPaw mentioned this issue Jun 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Refactor link previews thelounge/thelounge
3 participants
@xPaw @MiniDigger @raqbit