Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return an error when connecting to a forbidden network in locked mode #133

Closed
astorije opened this issue Mar 2, 2016 · 4 comments
Closed

Return an error when connecting to a forbidden network in locked mode #133

astorije opened this issue Mar 2, 2016 · 4 comments
Labels
Status: Duplicate Tickets already solved/opened in the past. Should always link to the ticket they duplicate. Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.

Comments

@astorije
Copy link
Member

astorije commented Mar 2, 2016

When setting lockNetwork to true (added in #82) and trying to connect to a server that is not the authorized one using /connect, we get no output at all, even though the code path accounts for an error response.
@astorije astorije added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Mar 2, 2016
@xPaw
Copy link
Member

xPaw commented Mar 2, 2016

I think the solution is to create server window on the client as soon as possible, instead of waiting for a connection to be opened.

@maxpoulin64
Copy link
Member

Agreed. That's how all clients do it, we definitely should always open the server window as soon as possible to show either error messages or success messages.

@xPaw
Copy link
Member

xPaw commented Mar 4, 2016

Closing this issue since it's practically a duplicate #115

@xPaw xPaw closed this as completed Mar 4, 2016
@astorije
Copy link
Member Author

astorije commented Mar 5, 2016

Indeed, thanks and sorry @xPaw!

@astorije astorije added the Status: Duplicate Tickets already solved/opened in the past. Should always link to the ticket they duplicate. label Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Duplicate Tickets already solved/opened in the past. Should always link to the ticket they duplicate. Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@astorije @xPaw @maxpoulin64