Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move styles from style.css to components #1551

Open
xPaw opened this issue Sep 20, 2017 · 4 comments
Open

Move styles from style.css to components #1551

xPaw opened this issue Sep 20, 2017 · 4 comments
Labels
help wanted Tickets the community can help us with, by either answering questions or sending us PRs. Type: Feature Tickets that describe a desired feature or PRs that add them to the project.

Comments

@xPaw
Copy link
Member

xPaw commented Sep 20, 2017

Our style.css is over 2000 lines long, and it's a mess. We definitely need to split it into some smaller components like we did with javascript code.

And then as a build step have it assembled and minified (auto prefixed too!) into a single file.
@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Sep 20, 2017
@astorije astorije added Type: Feature Tickets that describe a desired feature or PRs that add them to the project. and removed Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. labels Sep 21, 2017
This was referenced Sep 21, 2017
Merged
Merged
@xPaw xPaw added Hacktoberfest help wanted Tickets the community can help us with, by either answering questions or sending us PRs. labels Oct 1, 2017
@xPaw xPaw removed the hacktoberfest label Nov 2, 2017
@ESWAT ESWAT mentioned this issue Mar 13, 2018
Closed
@xPaw xPaw changed the title Split style.css into subcomponents and preprocess css as a build step Move styles from style.css to components Jan 24, 2020
@xPaw
Copy link
Member Author

xPaw commented Jan 24, 2020

We are able to move styles into their vue components now, we should do that.

@MaxLeiter MaxLeiter mentioned this issue Feb 24, 2022
Closed
@bumpylumps
Copy link

If this is still open I'd be happy to break up that CSS!

@MaxLeiter
Copy link
Member

MaxLeiter commented May 9, 2022 •
edited

@bumpylumps currently I'd wait for #4559, and then if you want to update #4494 feel free. I don't think a PR converting all the styles like I initially attempted is necessary. I think it'd be better to just port things like StyledButton (https://github.com/thelounge/thelounge/pull/4494/files#diff-e659b73c252ec4acfef1225984f63bfd6f934c09765099895eedd23e83080f70) and we can port the rest incrementally when we modify the components.

@bumpylumps
Copy link

@bumpylumps currently I'd wait for #4559, and then if you want to update #4494 feel free.

Sounds good! I'll keep an eye on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Tickets the community can help us with, by either answering questions or sending us PRs. Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Break up style.css and move styles to components thelounge/thelounge
4 participants
@astorije @xPaw @MaxLeiter @bumpylumps