Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor monospace styling when links are included #2276

Open
xPaw opened this issue Mar 22, 2018 · 4 comments
Open

Poor monospace styling when links are included #2276

xPaw opened this issue Mar 22, 2018 · 4 comments
Labels
help wanted Tickets the community can help us with, by either answering questions or sending us PRs. Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.

Comments

@xPaw
Copy link
Member

xPaw commented Mar 22, 2018

22-181354918

curl "https://imgur.com/gallery/ePXOk" -H "accept: text/html"

  • Parser splits irc-monospace across multiple elements which is causing extra padding (e.g. after ").
  • Link caret breaks the monospace styling
@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Mar 22, 2018
@xPaw
Copy link
Member Author

xPaw commented Mar 22, 2018

It's also pretty silly with emojis:

22-184042350

@xPaw xPaw added the help wanted Tickets the community can help us with, by either answering questions or sending us PRs. label Mar 22, 2018
@xPaw
Copy link
Member Author

xPaw commented Mar 22, 2018

Related: #1783

@xPaw xPaw mentioned this issue Mar 22, 2018
Open
@astorije
Copy link
Member

If someone is wondering, current markup for this looks like:

screen shot 2018-03-22 at 14 37 54

@xPaw
Copy link
Member Author

xPaw commented Sep 25, 2018

This is also super confusing for example in /join #test1 due to padding it looks like theres 2 spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Tickets the community can help us with, by either answering questions or sending us PRs. Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astorije @xPaw