Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slideout menu bar for mobile #393

Closed
karbowiak opened this issue Jun 10, 2016 · 7 comments
Closed

Slideout menu bar for mobile #393

karbowiak opened this issue Jun 10, 2016 · 7 comments
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Milestone

Comments

@karbowiak
Copy link

Hi there..

Currently i find myself constantly sliding my thumb from the left side, to the right, to get to the sidebar with all the channels, all to no avail.

Something like https://mango.github.io/slideout/ could fix that i'm sure (i suck at JS to be honest) :)

@astorije astorije added Type: Feature Tickets that describe a desired feature or PRs that add them to the project. help wanted Tickets the community can help us with, by either answering questions or sending us PRs. labels Jun 10, 2016
@astorije
Copy link
Member

Whoever takes this, please share design decision here. In particular, if using a third-party library, explore options and let us know why one more than the others :-)

@xPaw
Copy link
Member

xPaw commented Jun 10, 2016

Yeah it's really hard to find an actually good library for this. Just tried Slideout.js, it's not awful, but it has some delay/lag issues.

@maxpoulin64 maxpoulin64 added help wanted and removed help wanted Tickets the community can help us with, by either answering questions or sending us PRs. labels Jun 11, 2016
@maxpoulin64
Copy link
Member

I just swapped the label to help wanted, because it's really not an easy one so it's definitely not an up for grabs.

@dgw
Copy link
Contributor

dgw commented Jun 11, 2016

Caught myself trying to slide out the side menu yesterday, but it's not exactly a common feature for webapps to support. I can't think of one that does off the top of my head.

Would be a real feather in The Lounge's cap if this was implemented, though. The few, the proud, the menu-sliders!

@maxpoulin64
Copy link
Member

Annnnd here we go!

Probably needs a bit of tweaking to fit The Lounge, but it works.

@maxpoulin64
Copy link
Member

Alternatively, it seems like this is the cause of the delay in the existing one, so it should be relatively easy to fix upstream and we could then use this implementation and throw away mine.

@astorije
Copy link
Member

For what it's worth, I was pointed to https://events.google.com/io2016/ as a decent-looking implementation of a slideout menu. I haven't looked at the code at all, so I don't know if we can make any use of this (like if it's not possible to know which lib they are using...).

@astorije astorije added this to the Next Release milestone Jul 6, 2016
@xPaw xPaw modified the milestones: 2.1.0, Next Release Oct 2, 2016
@xPaw xPaw closed this as completed Oct 2, 2016
@xPaw xPaw removed the help wanted label Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

No branches or pull requests

5 participants