Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/msg to nonexistent window eats the message without logging #4538

Open
dgw opened this issue Apr 16, 2022 · 2 comments
Open

/msg to nonexistent window eats the message without logging #4538

dgw opened this issue Apr 16, 2022 · 2 comments

Comments

@dgw
Copy link
Contributor

dgw commented Apr 16, 2022

I was shocked to note that TL still "just eats the message" if I initiate a /msg to some other user without first opening a window with /query othernick. The first time it happened, I wasn't even sure my message had been sent until the other user woke up (I assume) and replied.

If logging is turned on, it should be impossible for any message to just bypass the logs and never get saved. Users will distrust TL's logging features if they demonstrate unreliability.

Original comment by me in #590 (comment)

@xPaw
Copy link
Member

xPaw commented Apr 17, 2022

Was this on a server without echo-message? Because that should be the common case where it doesn't get logged here:

if (!network.irc.network.cap.isEnabled("echo-message")) {

That or the message was not actually sent (thus echo message is not being triggered).

@dgw
Copy link
Contributor Author

dgw commented Apr 17, 2022

The message was sent; the recipient replied some hours later.

On this network (Rizon), the lobby status messages include Enabled capabilities: away-notify, chghost, invite-notify, multi-prefix, sasl, userhost-in-names. Seems you're correct about this being a network without echo-message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants