Change genome build to GRCm39 for GENCODE release M26 and later #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this! I'll push to release and devel. |
|
Thanks, I've pushed and added a note to news for release and devel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mikelove - we just noticed that the recent GENCODE mouse releases are still linked to GRCm38: https://github.com/thelovelab/tximeta/blob/devel/inst/extdata/hashtable.csv#L24-L31
I believe that from version M26, this should be GRCm39 (https://www.gencodegenes.org/mouse/releases.html). We noticed since when importing data quantified against a new GENCODE version,
tximetawould complain that some features were out of bounds.This PR changes the genome build for GENCODE vM26 and later.