Branch flash pr with large eeprom #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/knx/application_program_object.cpp # src/knx/bau27B0.cpp # src/knx/bau57B0.cpp # src/knx/bits.h # src/knx/config.h # src/knx/ip_data_link_layer.cpp # src/knx/knx_ip_search_response.cpp # src/knx/memory.cpp # src/knx/network_layer.cpp # src/knx/rf_data_link_layer.cpp # src/knx/rf_medium_object.cpp # src/knx/rf_physical_layer_cc1101.cpp # src/knx/tpuart_data_link_layer.cpp
# Conflicts: # src/rp2040_arduino_platform.cpp # src/rp2040_arduino_platform.h
added stdlib and defines
# Conflicts: # src/rp2040_arduino_platform.cpp
improvements in RP2040 plattform
bugfix when calculating memorywrites over multiple blocks by mumpf
…m/SirSydom/knx into Branch_flash_pr_with_large_eeprom
thelsing
reviewed
Feb 20, 2022
src/rp2040_arduino_platform.h
Outdated
| @@ -13,11 +23,36 @@ class RP2040ArduinoPlatform : public ArduinoPlatform | |||
| void setupUart(); | |||
|
|
|||
| // unique serial number | |||
| uint32_t uniqueSerialNumber() override; | |||
| uint32_t uniqueSerialNumber(); //override; | |||
There was a problem hiding this comment.
when i started with the flash branch master was not merged into flash branch and uniqueSerialNumber not defined (so the override caused a compile error).
override is optional anyway, so i removed it. It can be added again, no problem.
- changed alignment from flashpagesize to 32bit - added override modifier (PR discussion) - changed comment regarding flash/eeprom functions for plattforms to override/implement (PR discussion)
|
Merged. Thanks. |
rueckix
added a commit
to rueckix/knx
that referenced
this pull request
Apr 29, 2022
Addresses a side effect of thelsing#177, which causes the eeprom buffer to be overwritten every time getEepromBuffer is called. This prevented programming of STM32 boards as their initial bus address was lost before programming.
thelsing
pushed a commit
that referenced
this pull request
Apr 30, 2022
* Update stm32_platform.cpp Addresses a side effect of #177, which causes the eeprom buffer to be overwritten every time getEepromBuffer is called. This prevented programming of STM32 boards as their initial bus address was lost before programming. * Code style fix
rueckix
added a commit
to rueckix/knx
that referenced
this pull request
May 27, 2022
Addresses a side effect of thelsing#177, which causes the eeprom buffer to be overwritten every time getEepromBuffer is called. This prevented programming of STM32 boards as their initial bus address was lost before programming.
thelsing
pushed a commit
that referenced
this pull request
May 31, 2022
* Update stm32_platform.cpp Addresses a side effect of #177, which causes the eeprom buffer to be overwritten every time getEepromBuffer is called. This prevented programming of STM32 boards as their initial bus address was lost before programming. * progbutton fix * Update stm32_platform.cpp Addresses a side effect of #177, which causes the eeprom buffer to be overwritten every time getEepromBuffer is called. This prevented programming of STM32 boards as their initial bus address was lost before programming. * Update knx_facade.h Remove superfluous attribute _buttonPinInterruptOn * Update knx_facade.h attachInterrup on CHANGE for progbutton detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #176