Quest log in var db/quest-log #511
Conversation
|
the bitmasking seems wrong.. |
|
Aye, @omattornot you need to replace the VAR name in the quest with the new var. Look at the other quests or chat with us in IRC. |
…. (orum,furquest,caretaker
…on in hinnak script
world/map/db/quest-log.txt
Outdated
| @@ -28,3 +28,10 @@ | |||
| 20,QL_TERRANITE_ARMOR,QUEST_NorthTulimshar,6,4 | |||
| // 21 => assassin quest | |||
| 22,QL_CELESTIA,QUEST_Hurnscald,2,8 | |||
| 23,QL_Caretaker,QUEST_Graveyard_Caretaker,0,4 | |||
There was a problem hiding this comment.
All QL_ variables should be in ALL CAPS
QUEST_Graveyard_Caretaker should be moved to an existing bitmasked var, and converted in clear_vars. It only needs 3 bits so we can fit it easily somewhere
world/map/npc/011-6/barrier.txt
Outdated
|
|
||
| if (@state >= 6) goto L_Lord_Hideout_Open; | ||
| if (@QL_Bandit >= 6) goto L_Lord_Hideout_Open; |
…on in clear_vars; update and fix some things about comments of last commit
|
@omattornot you need to rebase. Let me know when you fix the conflict so I can restart test-server. |
|
@wushin I fixed the conflict. But what rebase i need to do ? Squash all commit in one ? |
|
@omattornot the conflict was the rebasing. |
|
@omattornot is this done? if yes I'll review again. @wushin feel free to check too |
|
I'm not going to merge this, it needs a bit more than just a rebase at this point 😰 I'm closing but if you want to fix and try again, please, be my guest. This is by no means a rejection, just spring cleaning. |
I add the var for new quest-log of letter, orum and fur quest.