Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not save default settings to database #110

Closed
middlesister opened this issue Jul 9, 2014 · 0 comments
Closed

do not save default settings to database #110

middlesister opened this issue Jul 9, 2014 · 0 comments
Milestone
2.0

Comments

@middlesister
Copy link
Member

new in Theme Review Guidelines for 3.9
See http://make.wordpress.org/themes/2014/07/09/using-sane-defaults-in-themes/
@middlesister middlesister added this to the 2.0 milestone Jul 10, 2014
middlesister added a commit that referenced this issue Jul 26, 2014
@middlesister
Unit tests: Don't pre-populate database with theme options
deebd99 
See #110
middlesister added a commit that referenced this issue Jul 26, 2014
@middlesister
Remove automatic adding of theme options to database
8f085d9 
See #110
middlesister added a commit that referenced this issue Jul 26, 2014
@middlesister
Use thematic_default_opt() in theme options upgrade check
f1288ce 
See #110
middlesister added a commit that referenced this issue Jul 26, 2014
@middlesister
Parse in default theme options in thematic_get_theme_opt()
5a43b80 
Use wp_parse_args() to use default theme options even when no
options have been saved to the database yet.

See #110
middlesister added a commit that referenced this issue Jul 26, 2014
@middlesister
Use thematic_get_wp_opt() in thematic_default_theme_layout()
8a87bfe 
Previous use of thematic_get_theme_opt() caused an infinite
loop since thematic_get_theme_opt() now fallbacks to
thematic_default_opt() which calls thematic_default_theme_layout().

Using thematic_get_wp_opt() ensures we actually check if database
option exists or not.

See #110
@middlesister middlesister mentioned this issue Jul 26, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@middlesister