Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] - Embedded youtube video in article always plays from 00:00 even with start time parameter. #203

Closed
devformatters opened this issue Aug 10, 2020 · 3 comments · Fixed by #364

Comments

@devformatters
Copy link
Contributor

Describe the bug
Embedded youtube video in article always plays from 00:00 even with start time parameter such as ?t=10.

To Reproduce
Steps to reproduce the behavior:

  1. Open editor toolbar
  2. Click embed video button
  3. Paste youtube video link with start time parameter
  4. After embed, play the video

Expected behavior
Video show starts from specific time.

@guoliu
Copy link
Contributor

guoliu commented Aug 12, 2020

@devformatters do you think this is a front end issue, i.e. is the start time parameter persevered in iframe source but player doesn't work correctly?

@devformatters
Copy link
Contributor Author

@devformatters do you think this is a front end issue, i.e. is the start time parameter persevered in iframe source but player doesn't work correctly?

It looks like we remove query parameter while processing url.

@guoliu
Copy link
Contributor

guoliu commented Aug 28, 2020

@devformatters do you think this is a front end issue, i.e. is the start time parameter persevered in iframe source but player doesn't work correctly?

It looks like we remove query parameter while processing url.

Sounds good, moving this to editor repo then.

@guoliu guoliu transferred this issue from thematters/developer-resource Aug 28, 2020
@guoliu guoliu added this to To do in Enhancements & Bugs via automation Aug 28, 2020
@robertu7 robertu7 moved this from To do to Select for development in Enhancements & Bugs Sep 21, 2020
@guoliu guoliu moved this from Select for development to To do in Enhancements & Bugs Sep 22, 2020
@devformatters devformatters added this to To do in 🚀 Dev Oct 6, 2020
@devformatters devformatters moved this from To do to Pre to-do in 🚀 Dev Nov 25, 2020
@devformatters devformatters moved this from Pre to-do to Community in 🚀 Dev Mar 11, 2021
@devformatters devformatters moved this from Community to Evaluating in 🚀 Dev Sep 28, 2021
@devformatters devformatters moved this from Evaluating to To do in 🚀 Dev Sep 28, 2021
@devformatters devformatters changed the title Embedded youtube video in article always plays from 00:00 even with start time parameter. [Editor] - Embedded youtube video in article always plays from 00:00 even with start time parameter. Sep 28, 2021
@guoliu guoliu moved this from To do to Review in progress in 🚀 Dev Oct 6, 2021
@tx0c tx0c closed this as completed in c863021 Oct 6, 2021
Enhancements & Bugs automation moved this from To do to Done Oct 6, 2021
@devformatters devformatters moved this from Review in progress to Done in 🚀 Dev Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants