Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mention): remove mention* props #369

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(mention): remove mention* props #369

wants to merge 1 commit into from

Conversation

tx0c
Copy link
Contributor

@tx0c tx0c commented Oct 6, 2021

this is picked up from PR #195 rebased to latest develop

removing the mentionInstance can avoid the ref change caused ReactQuill always initialize Quill twice, help resolve part thematters/matters-web#2114

References #192

@robertu7 @tx0c
feat(mention): remove mention* props
110ec3e 
this is picked up from PR #195 rebased to latest develop

but why #192 relevant?
@tx0c tx0c requested a review from a team as a code owner October 6, 2021 03:02
guoliu
guoliu approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@guoliu guoliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👊💪🌱

@robertu7 robertu7 self-requested a review October 6, 2021 05:12
robertu7
robertu7 approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@robertu7 robertu7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new implementation of mention feature needs to be added to matters-web first?

@tx0c
Copy link
Contributor Author

tx0c commented Oct 6, 2021

💥 💥 💥

@guoliu guoliu linked an issue Oct 7, 2021 that may be closed by this pull request
[Editor] - Code block eats up lines if it's added in the beginning of article content #374
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertu7 robertu7 robertu7 approved these changes

@guoliu guoliu guoliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Editor] - Code block eats up lines if it's added in the beginning of article content
3 participants
@tx0c @robertu7 @guoliu