Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tag cover fallback runs incorrectly #1414

Closed
jeremyOk opened this issue Aug 12, 2020 · 2 comments · Fixed by #1424 or #1408
Closed

tag cover fallback runs incorrectly #1414

jeremyOk opened this issue Aug 12, 2020 · 2 comments · Fixed by #1424 or #1408
Assignees
@devformatters
Labels
bug Something isn't working

Comments

@jeremyOk
Copy link
Contributor

Describe the bug
Some covers of tag are still vacant although covers of articles in the tag can be found.

Screenshots

image

Desktop (please complete the following information):

  • MacOS
  • Chrome
@guoliu
Copy link
Contributor

guoliu commented Aug 12, 2020

This looks like a backend issue - API should return cover of article if tag article cannot be found (pls correct me if I'm wrong @devformatters ). Moving to server repo now.

@guoliu guoliu transferred this issue from thematters/developer-resource Aug 12, 2020
@guoliu guoliu added the bug Something isn't working label Aug 12, 2020
@robertu7
Copy link
Contributor

@devformatters Was it fixed? If so, please close this issue.

This was linked to pull requests Sep 16, 2020
fix(resolver): change query of tag fallback cover #1424
Merged
fix(service): change tag cover fallback logic #1408
Merged
@guoliu guoliu closed this as completed Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devformatters devformatters

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@robertu7 @guoliu @devformatters @jeremyOk