Fix/xss sanity check #2285
Merged
Fix/xss sanity check #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
part of reason for thematters/matters-web#2114 is server not saving exactly same pre code-block, as
<pre class="ql-syntax" spellcheck="false">Pre1\n</pre><p>next paragraph...
server side is always dropping the `spellcheck="false"`, then next time when editor is loading
the pre code-block incomplete, it triggers `clipboard.convert` to parse again, and in MattersArticleEditor
the `mentionContainer` reference is causing ReactQuill to re-initialize twice every time, caused
converting between `HTML <=> Delta` happening 6 or even more times, and eventually caused wrong parsing
Codecov Report
@@ Coverage Diff @@
## develop #2285 +/- ##
========================================
Coverage 53.94% 53.94%
========================================
Files 412 412
Lines 10398 10398
Branches 2026 2026
========================================
Hits 5609 5609
Misses 4783 4783
Partials 6 6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make unittest for server side for sure not to touch the pre code-block … 0341e8f
part of reason for thematters/matters-web#2114 is server not saving exactly same pre code-block, as
server side is always dropping the
spellcheck="false", then next time when editor is loadingthe incomplete pre code-block, it triggers
clipboard.convertto parse again, and in MattersArticleEditorthe
mentionContainerreference is causing ReactQuill to re-initialize twice every time, causedconverting between
HTML <=> Deltahappening 6 or even more times, and eventually caused wrong parsingsanitize xss filter whitelist pre: ['spellcheck'] 3c9fccc