Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy Loading #1159

Merged
merged 20 commits into from
Jun 2, 2020
Merged

Lazy Loading #1159

merged 20 commits into from
Jun 2, 2020

Conversation

robertu7
Copy link
Contributor

@robertu7 robertu7 commented May 28, 2020

  • Add loading=lazy to <img> and <iframe>
    • Insert this attribute to article content;
    • Use <img> with object-fit: cover instead of inline backgroundImage for avatar & digest cover;
  • Dynamic Imports <AppreciatorsDialog>, <Donation>, <PushInitializer>, <ProgressBar> & <GlobalDialogs>
  • Upgrade @tippyjs/react to 4.x;
  • Drop custom express server;
  • Code Spliting of Icons

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #1159 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1159   +/-   ##
========================================
  Coverage    90.00%   90.00%           
========================================
  Files            1        1           
  Lines           10       10           
  Branches         2        2           
========================================
  Hits             9        9           
  Misses           1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 945a72f...e13b4e0. Read the comment docs.

@robertu7
Copy link
Contributor Author

@robertu7 robertu7 changed the title WIP: Lazy Loading Lazy Loading May 29, 2020
@robertu7 robertu7 added the ready label May 29, 2020
Copy link
Contributor

@guoliu guoliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and huge 🐳 not able to review all the files, but lets try and see!

# Conflicts:
#	package-lock.json
#	package.json
@robertu7 robertu7 merged commit 2b6cca5 into develop Jun 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/lazy-loading branch June 2, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants