Removed strtolower() when preparing URL. #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for this and great catch - as per 3.4.2.1 in the OAuth spec the scheme and host MUST be lowercase, but not the path. your diff fixes the path but leave the schema and host exposed to mixed case issues. instead i was going to do this: if you can update your diff to match that, i'll merge your pull request in. |
themattharris
pushed a commit
that referenced
this pull request
Sep 4, 2012
- changed version numbers to x.y.z format - stronger method scoping (public and private) - Typo fix in depenencies. (Issue #42) Props: tantek - Only lowercase the host and scheme, and not path, in prepare_url. (Issue #56) Props: uzyn - Fixed a number of PHP warnings by changing some tmhUtilty methods to static. (Issue #52) Props: DrayChou - Raw headers and response body are now available as `$tmhOAuth->response['raw']` - Moved the examples to their own repository <https://github.com/themattharris/tmhOAuth-examples> - Removed the `noexamples` branch as master does not contain examples anymore - Introduced `$tmhOAuth->config['timezone']` and set `date_default_timezone_set`. (Issue #70) Props: iamctodd
|
all merged into 0.70. props given in readme and the commit message |
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some providers, like LinkedIn, uses a case-sensitive URL which includes capital letters.
Some examples:
https://api.linkedin.com/uas/oauth/requestToken
https://api.linkedin.com/uas/oauth/accessToken
Reference: https://developer.linkedin.com/documents/linkedins-oauth-details