Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not add hover text for pv/uv? [solved] #108

Closed
3 tasks done
xu-song opened this issue Feb 3, 2018 · 7 comments
Closed
3 tasks done

Why not add hover text for pv/uv? [solved] #108

xu-song opened this issue Feb 3, 2018 · 7 comments
Labels

Comments

@xu-song
Copy link
Contributor

xu-song commented Feb 3, 2018

I agree and want to create new issue


Expected behavior

hover text for PV&UV, instead of header&footer.

Hover text is more concise than footer & header.

pls goto changes a674f35

Actual behavior

only header & footer is availabel.

Steps to reproduce the behavior

  1. N/A
  2. N/A
  3. N/A
@sli1989
Copy link
Collaborator

sli1989 commented Feb 3, 2018

add or replace in site_uv_header and site_pv_header?

@xu-song
Copy link
Contributor Author

xu-song commented Feb 3, 2018

I have take a pull request. The changes can be seen a674f35

@sli1989
Copy link
Collaborator

sli1989 commented Feb 3, 2018

i mean you can just add sth in site_uv_header and site_pv_header like site_uv_header: <i class="fa fa-user"></i> 本站来访数 . It already includes the custom style.

@xu-song
Copy link
Contributor Author

xu-song commented Feb 3, 2018

They are different. @sli1989

The following is the effect of site_uv_header: <i class="fa fa-user"></i> site_uv

default

It is not hover text in your config. You can check the demo with hover text see site_pv, site_uv, page_pv
In many cases, hover text is more favorable, such as page_pv in the above demo.
default
It is mouseover text with HTML.
default

@xu-song xu-song mentioned this issue Feb 3, 2018
15 tasks
@sli1989
Copy link
Collaborator

sli1989 commented Feb 4, 2018

yeah, thanks, got it.

@ivan-nginx
Copy link
Member

ivan-nginx commented Feb 8, 2018

@xu-song @sli1989 i don't use this service and not totally understand what is this, but i think all titles must at least have translated languages in similar directory of NexT theme.
NexT is multilanguage theme. So, i think non-Chinese people will not pretty good to see in default configuration Chinese (or any other) languages. U will be glad if i'll add in default config something like:

new_cool_feature:
  enabled: true
  title: Привет! Вся конфигурация вроде-бы на Английском, но вот именно эта опция таки на Русском. А что такого то?

So, please, add i18n support in pull #110.

@xu-song xu-song mentioned this issue Feb 9, 2018
15 tasks
@wafer-li
Copy link
Member

Solved by #129

@ivan-nginx ivan-nginx changed the title why not add hover text for pv/uv? why not add hover text for pv/uv? [fixed / refactored] Mar 17, 2018
@ivan-nginx ivan-nginx changed the title why not add hover text for pv/uv? [fixed / refactored] Why not add hover text for pv/uv? [solved] Mar 4, 2019
@theme-next theme-next locked as resolved and limited conversation to collaborators Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants