Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preview link for Firefox #54

Closed
andreicristianpetcu opened this issue Apr 20, 2020 · 2 comments
Closed

Add preview link for Firefox #54

andreicristianpetcu opened this issue Apr 20, 2020 · 2 comments

Comments

@andreicristianpetcu
Copy link

andreicristianpetcu commented Apr 20, 2020 •
edited

The easiest way to distribute/install Firefox themes is with https://color.firefox.com/

It would be really cool if we had a preview link.

Chrome
Firefox (preview)
Sketch palettes

the link on desktop shows this (it does not work on mobile)
Screenshot_20200420-174914_Firefox_Nightly
@andreicristianpetcu andreicristianpetcu mentioned this issue Apr 20, 2020
Merged
@andreicristianpetcu
Copy link
Author

this is how the theme is converted to the URL in the Color extension and site
https://github.com/mozilla/FirefoxColor/blob/a43d5c66c7dc6f644f4e42e6a53ed1df9e19f099/src/web/index.js#L45-L50

mjswensen added a commit that referenced this issue Apr 21, 2020
@mjswensen
Add Firefox Color to web UI
31ab98c 
Resolves #48 and #54.
@mjswensen mjswensen mentioned this issue Apr 21, 2020
Closed
@mjswensen
Copy link
Collaborator

mjswensen commented Apr 21, 2020 •
edited

Resolved in 31ab98c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreicristianpetcu @mjswensen