Unable to change color of Dropdown parent button #934
Replies: 13 comments
-
I would say this is related also to this issue with the width: #905. As far as we are speaking about colors here, I would ask also to add the gray color without having to customize it via theme. Is it possible? |
Beta Was this translation helpful? Give feedback.
-
@meddouribadis @victorfunes For adding classNames to the button instead of the items, you are right, I think it should be a default prop for the component. |
Beta Was this translation helpful? Give feedback.
-
Hi @DavideFrancescon ,
But it only affects to the floating menu and not to the button itself. Sorry if it is my mistake or missunderstanding. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Here it goes:
|
Beta Was this translation helpful? Give feedback.
-
My mistake I did not the last test with the theme, now it works:
|
Beta Was this translation helpful? Give feedback.
-
@rluders @tulup-conner both this and the issue mentioned above can be closed I think. |
Beta Was this translation helpful? Give feedback.
-
@DavideFrancescon I agree with you, but I would recommend to change the theme name for the button in the Dropdown, as floating.target does not sound as the button style (it is not intuitive at all, as floating sounds like something related to the dropdown items menu, isn't it?) |
Beta Was this translation helpful? Give feedback.
-
Yes it's not, but every component has the same keys in the theme, so if I were to change this (other than break every old website using it), it would be the only one with a different name. So yea, it's not intuitive but it's too late to change it now. |
Beta Was this translation helpful? Give feedback.
-
I was refering not to change "target" but the the structure of the theme. |
Beta Was this translation helpful? Give feedback.
-
Yea it's a good solution, but it would still destroy every old site using the one there is now. The only solution is to leave both of them, and i'm in no position to do it without authorizations. |
Beta Was this translation helpful? Give feedback.
-
Hey all, thanks for your patience. So I definitely agree that the Like @DavideFrancescon mentioned, it will break existing themes, but that's fine if we're able to find a more intuitive name - that's the point of running this all in a "alpha/beta" stage. I will say in this particular case, Does something like |
Beta Was this translation helpful? Give feedback.
-
Hi, I am using inline dropdown but unable to change the text color it remain black I tried using tailwind styles but it doesn't work. Plz help me! |
Beta Was this translation helpful? Give feedback.
-
Steps to reproduce
Below is a React function in which I pass tailwind CSS classes to my dropdown element, but the parent button does not receive the classes but it is the child elements of the dropdown that receive them instead. It's impossible to change the color of the Dropdown without creating a specific CSS class.
Current behavior
Dropdown's parent button does not receive classes. The child elements yes.
Expected behavior
The parent button should receive the classes and not the children. The way around this is to create a custom theme and activate the inline prop as in the example below which is a bit complicated to just change the color of the dropdown button.
Context
I'm looking to add classes to my dropdown.
Thanks for your help !
Beta Was this translation helpful? Give feedback.
All reactions