Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinners do not have an accessible name #104

Closed
tulup-conner opened this issue May 11, 2022 · 0 comments
Closed

Spinners do not have an accessible name #104

tulup-conner opened this issue May 11, 2022 · 0 comments

Comments

@tulup-conner
Copy link
Collaborator

tulup-conner commented May 11, 2022

Describe the bug
Spinners are an <svg> with role="status", but they do not have an accessible label.

To Reproduce
Steps to reproduce the behavior:

  1. Create a <Spinner />
  2. Observe that screen reader skips over it, or notifies of a status, but with no explanation as to what it is

Expected behavior
Examples should contain an accessible name.

@rluders @bacali95 Users might want to provide a separate element rather than label the Spinner directly, which means there ideally would be flexibility between assigning aria-label and aria-labelledby. So I'm hesitant to say add a prop here, and instead I think it would be best to accept all HTML attributes and add accessible names to the examples. Thoughts?

Screenshots
n/a

Additional context
I've tried this on Apple VoiceOver so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant