fix: carousel init bug

[abdulbasithqb]

fix: carousel init bug

Changes:

Added Overflow Props to ScrollContainer

Why:

fixes: #1283

Screen-record:

Screen.Recording.2024-03-11.at.4.01.15.PM.mov

Summary by CodeRabbit

• Style
  • Updated the Carousel component to enable horizontal scrolling.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flowbite-react	❌ Failed (Inspect)			Mar 18, 2024 6:11am

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (7461173) to head (3c86b44).
Report is 202 commits behind head on main.

❗ Current head 3c86b44 differs from pull request most recent head e93f133. Consider uploading reports for the commit e93f133 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
- Coverage   99.54%   95.53%   -4.02%     
==========================================
  Files         163      217      +54     
  Lines        6621     9666    +3045     
  Branches      401      558     +157     
==========================================
+ Hits         6591     9234    +2643     
- Misses         30      432     +402     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rluders]

@coderabbitai review

[coderabbitai]

Walkthrough

This update introduces a straightforward yet effective change to the Carousel component, specifically by adding an inline style to enable horizontal scrolling (overflowX: 'scroll'). This adjustment aims to enhance the component's usability, particularly addressing an initialization bug that affected the Carousel's functionality upon first page load.

Changes

File Path	Change Summary
src/components/Carousel/...	Added inline style overflowX: 'scroll'

Assessment against linked issues

Objective	Addressed	Explanation
Carousel init bug (#1283)	✅

Poem

🐇 "In the realm of code, a tiny fix we sew,
🎠 Carousel now scrolls, with a gentle flow.
A bug once lurked, in the page's first glow,
❌ Now vanquished it lies, with nowhere to go.
🌟 To developers and users, a smoother show."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 31c9d9d and 06c9af2.

Files selected for processing (1)

• src/components/Carousel/Carousel.tsx (1 hunks)

Additional comments: 1

src/components/Carousel/Carousel.tsx (1)

• 154-154: The addition of style={{ overflowX: 'scroll' }} to the ScrollContainer is a straightforward approach to address the carousel's initialization issue. This change should ensure that the carousel is scrollable horizontally from the initial page load, which is crucial for the correct display and functionality of the carousel items.

However, it's important to consider the impact of this change on accessibility and performance. Specifically, ensure that this does not hinder keyboard navigation or screen reader usage. Additionally, if there are concerns about performance implications due to forcing scroll behavior, it might be worth exploring alternative solutions.

[rluders]

@abdulbasithqb please, don't use merge to sync with main, instead use rebase. Revert the merge and rebase, otherwise it won't be possible to accept the PR.

[abdulbasithqb]

@abdulbasithqb please, don't use merge to sync with main, instead use rebase. Revert the merge and rebase, otherwise it won't be possible to accept the PR.

closed this PR and raised a new one PR: #1305