-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(component): Rewrite Alert
s to use themes, resolves #126
#151
Merged
rluders
merged 8 commits into
themesberg:main
from
tulup-conner:feature/alert-use-theme
May 22, 2022
Merged
feature(component): Rewrite Alert
s to use themes, resolves #126
#151
rluders
merged 8 commits into
themesberg:main
from
tulup-conner:feature/alert-use-theme
May 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alert
s to use themes Alert
s to use themes
I was able to test this with the following code in my own app: <Alert color="primary">Test</Alert> It works great 💯 |
rluders
reviewed
May 21, 2022
rluders
reviewed
May 21, 2022
rluders
requested changes
May 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a few comments.
@rluders Using const theme: DeepPartial<FlowbiteTheme> = {
alert: {
color: {
primary: "bg-primary",
// Now provides suggestions while typing in VS Code
},
},
};
return (
<Flowbite theme={{ theme }}>
<Outlet />
</Flowbite>
); |
Alert
s to use themes Alert
s to use themes, resolves #126
Create a strict type for `FlowbiteTheme`.
We can use a modified version of `Partial` that deeply searches objects for partials. This lets you include any of the values in `FlowbiteTheme`, without needing to include all of them.
Replaces generic color names by semantic names: - `green` -> `success` - `yellow` -> `warning` - `red` -> `failure` - `info` -> `blue` This naming scheme makes it more immediately obvious which color to choose in many situations.
0ca2706
to
c65c426
Compare
This was referenced May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
None.
Features
Bug fixes