Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(component): Rewrite Breadcrumbs to use themes, resolves #129 #155

Merged
merged 6 commits into from
May 26, 2022

Conversation

tulup-conner
Copy link
Collaborator

@tulup-conner tulup-conner commented May 26, 2022

Breaking changes

Breadcrumbs can now be customized using <Flowbite theme={..}>.

breadcrumb: {
  item: {
    base: string;
    chevron: string;
    href: {
      off: string;
      on: string;
    };
    icon: string;
  };
  list: string;
};

Features

Tests

Unit

@tulup-conner
Copy link
Collaborator Author

Just need the className exclude helper to wrap this up

@tulup-conner tulup-conner force-pushed the feature/breadcrumb-theme branch 3 times, most recently from 50ec89d to 3085805 Compare May 26, 2022 07:06
@tulup-conner tulup-conner marked this pull request as ready for review May 26, 2022 07:07
@tulup-conner
Copy link
Collaborator Author

@rluders I think this should be ready now!

@tulup-conner
Copy link
Collaborator Author

tulup-conner commented May 26, 2022

BTW, I undid a change where I made it so you can't pass className to breadcrumb directly. We have an example in the docs that uses this (dark background). I don't really think that's an issue since we aren't controlling any classes on the breadcrumb parent (the <nav>)

Breadcrumb.Items are still blocked

We don't enforce any classes on the `Breadcrumb`
parent container itself, so there's no reason to
prevent `className` here, which actually breaks one
of our examples in the docs.
@rluders rluders merged commit 139c4ec into themesberg:main May 26, 2022
@tulup-conner tulup-conner deleted the feature/breadcrumb-theme branch May 26, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants