Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add $$resProps to Spinner #1000

Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix: add $$resProps to Spinner #1000

merged 1 commit into from
Aug 22, 2023

Conversation

vonagam
Copy link
Contributor

@vonagam vonagam commented Aug 19, 2023

📑 Description

Add $$resProps to Spinner.

Status

  • Not Completed
  • Completed

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

@stackblitz
Copy link

stackblitz bot commented Aug 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Aug 19, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2023 11:26am
flowbite-svelte-update ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2023 11:26am

@jjagielka
Copy link
Contributor

I'm OK with this PR

@shinokada shinokada merged commit 1dd97cd into themesberg:main Aug 22, 2023
4 checks passed
@vonagam vonagam deleted the fix-spinner-rest-props branch August 22, 2023 18:55
@vonagam
Copy link
Contributor Author

vonagam commented Aug 22, 2023

Hah, just noticed a type in my commit message resProps instead of restProps...

@shinokada
Copy link
Collaborator

Can you create another PR?

@vonagam
Copy link
Contributor Author

vonagam commented Aug 22, 2023

It is only in the commit message, not in the code.

@shinokada
Copy link
Collaborator

Thanks. Then it's ok.
Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vonagam @jjagielka @shinokada