Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts #1003

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Charts #1003

merged 2 commits into from
Aug 20, 2023

Conversation

jjagielka
Copy link
Contributor

@jjagielka jjagielka commented Aug 20, 2023

πŸ“‘ Description

  • Use svelte action for the component life cycle.
  • Use Card instead of ChartWrapper - Why to introduce new component if we already have one for that purpose?

Status

  • Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

β„Ή Additional Information

I couldn't resist to fine tune that.

@stackblitz
Copy link

stackblitz bot commented Aug 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Aug 20, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 20, 2023 8:40am
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 20, 2023 8:40am

@shinokada
Copy link
Collaborator

As I created an issue, it works before this PR: https://flowbite-svelte-b3tdqohtt-themesberg.vercel.app/ on iPad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants