Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Frame component to exports #1007

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Add Frame component to exports #1007

merged 1 commit into from
Aug 22, 2023

Conversation

selfagency
Copy link
Contributor

@selfagency selfagency commented Aug 22, 2023

πŸ“‘ Description

I tried to extend a component by copying its contents into my own file, but I ran into issues accessing the Frame component:

import Frame from 'flowbite-svelte/dist/utils/Frame.svelte';

results in:

Missing "./dist/utils/Frame.svelte" specifier in "flowbite-svelte" package

And:

import { Frame } from 'flowbite-svelte';

results in:

Module "flowbite-svelte" has no exported member 'Frame'.

This PR resolves the issue by adding the Frame component to the exports in src/lib/index.ts

Status

  • Not Completed
  • Completed

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

@stackblitz
Copy link

stackblitz bot commented Aug 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
flowbite-svelte βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 22, 2023 3:41pm
flowbite-svelte-update βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 22, 2023 3:41pm

@jjagielka
Copy link
Contributor

I'm OK with that PR.

@shinokada shinokada merged commit 017d886 into themesberg:main Aug 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants